Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove methods toJson and fromJson. #5989

Merged
merged 11 commits into from
Jul 7, 2023
Merged

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Jul 5, 2023

Use serialization for HeapSnapshotGraph, to serialize AdaptedHeapData.
It makes the code conciser and improve maintainability.

@polina-c polina-c marked this pull request as ready for review July 6, 2023 21:21
@polina-c polina-c requested review from bkonyi and a team as code owners July 6, 2023 21:21
@bkonyi
Copy link
Contributor

bkonyi commented Jul 7, 2023

Can you update the description? I don't have the context as to what this change is supposed to accomplish.

Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the coffee just needed to kick in. LGTM, but still consider updating the description :)

@polina-c polina-c changed the title Switch to native serialization for heap snapshot to reduce maintenance cost. Remove methods toJson and fromJson. Jul 7, 2023
@polina-c polina-c merged commit 58c1090 into flutter:master Jul 7, 2023
@polina-c polina-c deleted the no-json branch July 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants